Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitflags dependency #127

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

pattop
Copy link
Contributor

@pattop pattop commented Sep 27, 2023

Limiting bitflags to <2.1.0 causes compatibility issues and build failures with other crates, e.g:

error: failed to select a version for bitflags.
... required by package bindgen v0.68.1
... which satisfies dependency bindgen = "^0.68.1" of package ...
versions that meet the requirements ^2.2.1 are: 2.4.0, 2.3.3, 2.3.2, 2.3.1, 2.3.0, 2.2.1

all possible versions conflict with previously selected packages.

previously selected package bitflags v2.0.2
... which satisfies dependency bitflags = ">=1.3.1, <2.1.0" (locked to 2.0.2) of package serialport v4.2.2
... which satisfies dependency serialport = "^4.2.2" (locked to 4.2.2) of package ...

failed to select a version for bitflags which could resolve this conflict

Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up!

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Sorry, could you also add an entry to the changelog about this update?

Limiting bitflags to <2.1.0 causes compatibility issues and build
failures with other crates, e.g:

error: failed to select a version for `bitflags`.
    ... required by package `bindgen v0.68.1`
    ... which satisfies dependency `bindgen = "^0.68.1"` of package ...
versions that meet the requirements `^2.2.1` are: 2.4.0, 2.3.3, 2.3.2, 2.3.1, 2.3.0, 2.2.1

all possible versions conflict with previously selected packages.

  previously selected package `bitflags v2.0.2`
    ... which satisfies dependency `bitflags = ">=1.3.1, <2.1.0"` (locked to 2.0.2) of package `serialport v4.2.2`
    ... which satisfies dependency `serialport = "^4.2.2"` (locked to 4.2.2) of package ...

failed to select a version for `bitflags` which could resolve this conflict
@pattop
Copy link
Contributor Author

pattop commented Sep 29, 2023

Thank you! Sorry, could you also add an entry to the changelog about this update?

I've updated the patch.

@pattop pattop requested a review from eldruin September 29, 2023 00:04
@pattop pattop changed the title Relax bitflags dependency Update bitflags dependency Sep 29, 2023
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eldruin eldruin merged commit 1546d77 into serialport:main Sep 29, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants