Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report actual device file on Linux without udev #122

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Report actual device file on Linux without udev #122

merged 2 commits into from
Sep 5, 2023

Conversation

sirhcel
Copy link
Contributor

@sirhcel sirhcel commented Aug 23, 2023 •
edited
Loading

This addresses #66 by returning he expected device file paths instead the paths from /sys/class/tty.

@sirhcel sirhcel marked this pull request as draft August 23, 2023 20:55
@sirhcel
Copy link
Contributor Author

sirhcel commented Aug 23, 2023

I still waiting for some feedback from #66 (comment).

@sirhcel sirhcel force-pushed the issue-66-non-udev-enumeration-on-linux branch from b0a8730 to 6c5c1a4 Compare September 3, 2023 18:35
@sirhcel sirhcel marked this pull request as ready for review September 3, 2023 18:40
@sirhcel
Copy link
Contributor Author

sirhcel commented Sep 3, 2023

There has been no feedback in #66 so far. Let's go one step forward with this fix then.

eldruin
eldruin reviewed Sep 4, 2023
View reviewed changes
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thank you!
Could you add an entry to the changelog about this?

@sirhcel
Copy link
Contributor Author

sirhcel commented Sep 4, 2023

Alright, thank you! Could you add an entry to the changelog about this?

Thank you very much! I missed this out. :) Added.

eldruin
eldruin approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eldruin eldruin merged commit 48a0527 into serialport:main Sep 5, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirhcel @eldruin