Fixes the PCI-port bug on Raspberry Pi 4 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bug is caused by the Fact that the USB controller is connected to the CPU via PCI, which was not the case on the Raspberry Pi 3. Because of this, the BUS_ID reported by libudev is PCI. However, if it is an actual USB device, there will be fields containing the neccessary information to generate a UsbPortInfo. This patch checks whether all those fields are available, if the BUS_ID is Pci, and if so uses them to populate an UsbPortInfo and return a SerialPortType::UsbPort
eldruin
reviewed
Jul 27, 2023
eldruin
reviewed
Jul 27, 2023
eldruin
approved these changes
Jul 27, 2023
|
No problem, I actually need it myself ^^. The sooner it's on crates.io the happier I am :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bug is caused by the Fact that the USB controller is connected to
the CPU via PCI, which was not the case on the Raspberry Pi 3.
Because of this, the BUS_ID reported by libudev is PCI. However, if it
is an actual USB device, there will be fields containing the neccessary
information to generate a UsbPortInfo. This patch checks whether all
those fields are available, if the BUS_ID is Pci, and if so uses them to
populate an UsbPortInfo and return a SerialPortType::UsbPort
Fixes #110