fixed saveMedia function missing required parameter for uploadWeb #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention, this only started happening after I updated to the latest version 3.8.0 |
|
Is this "code" parameter ever used in the Web-Endpoint? |
|
Thanks, I missed that pull request when I noticed the issue. Forgot to look for pull requests that were already merged. Sorry about that in thanks! I will close this issue instead. Also, I agree, I was thinking of more of doing an emergency fix, so I just copied the parameters use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When choosing to upload any file using the web portal, it would cause an slim application error because the saveMedia function was missing an required parameter, as you can see in issue #627 which this pull request closes. Luckily though, uploading with an endpoint still works as expected