Add missing type_params attribute for ClassDef node before Python3.12
#89
Conversation
|
Thanks! Could you add a test case? |
gast/ast3.py
Outdated
| @@ -226,6 +237,18 @@ def visit_comprehension(self, node): | |||
| return ast.copy_location(new_node, node) | |||
|
|
|||
| if 8 <= sys.version_info.minor < 12: | |||
|
|
|||
| def visit_ClassDef(self, node): | |||
There was a problem hiding this comment.
if I'm not mistaken, it's not only for 8 <= sys.version_info.minor < 12 but just for sys.version_info.minor < 12, right?
otherwise looks good.
There was a problem hiding this comment.
Yes, the same code now exists in both 8 <= sys.version_info.minor < 12 and sys.version_info.minor < 8 branches, I'll put them together.
|
thanks 🙇 |
|
(btw in which context are you using |
I'm currently maintaining PaddlePaddle, a deep learning framework similar to PyTorch, and we need to rewrite the original dynamic graph functions at the source level as static graph functions with control flow operators. To ensure multi-version compatibility, we use Note For some historical reason unknown to me, the source code was copied to the PaddlePaddle repo and then used. This problem was also exposed after the upgrade, and I fixed it at PaddlePaddle (see PaddlePaddle/Paddle#68892). In order to prevent others from encountering the same problem, I thought it would be a good idea to fix it in Thanks for writing the |
|
Cool! Thanks for sharing :-) It would indeed be better not to vendor gast, should I submit a PR that fixes this in PaddlePaddle? |
Thanks, this issue has been fixed at PaddlePaddle/Paddle#68892. If we encounter similar issues in the future, we will also fix them and contribute them back to |
Add missing
type_paramsattribute forClassDefnode before Python 3.12.