Various: Make error messages more idiomatic #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tracing_subscriber dosn't support multiple |
FelixMcFelix
approved these changes
May 21, 2021
FelixMcFelix
pushed a commit
to FelixMcFelix/songbird
that referenced
this pull request
May 21, 2021
FelixMcFelix
pushed a commit
to FelixMcFelix/songbird
that referenced
this pull request
Jun 14, 2021
FelixMcFelix
pushed a commit
to FelixMcFelix/songbird
that referenced
this pull request
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently read the
std::error::Errortrait documentation and found that messages should (in general) be lowercase. After more searching I also found this which talks about howstd::error::Error::sourceshould behave (to produce nice error chains).This pull requests implements these lessons for most error types (I didn't want to touch some of
songbird::error::ConnectionError's errors (likesongbird::ws::Error) due to their complexity).Tested with
cargo make ready