Fixed strange behaviour for when the prefix has spaces #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
requested changes
Nov 12, 2017
src/framework/standard/command.rs
Outdated
| for i in 0..slice.len() { | ||
| // 0x20 is ASCII for space | ||
| match slice[i] { | ||
| 0x09 => {} // \t |
There was a problem hiding this comment.
Use | to group these up.
e. g
0x09 | 0x0a | 0x0d | 0x20 => {}
There was a problem hiding this comment.
Sure. (I'm not fluent with match cases hehe....)
arqunis
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last time I was in this section of code, I splitted the string by whitespaces then took the second element, ignoring whether the prefix has whitespaces in it or not. I re-implemented the function to prevent strange behaviours for prefixes with whitespaces, and also added cases for non-space whitespaces.