-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: attempt to fix nightly builds in next
branch
#1541
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
added
dependencies
Related to Serenity dependencies.
fix
A solution to an existing bug.
ci
Related to the continuous integration.
labels
Oct 10, 2021
Nice! It seems that the nightly builds now compile. The other checks seem to fail due to an error with the |
arqunis
approved these changes
Oct 10, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 29, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Nov 15, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Nov 15, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Dec 22, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Dec 23, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 23, 2022
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Mar 1, 2022
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Mar 15, 2022
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Apr 2, 2022
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
Related to the continuous integration.
dependencies
Related to Serenity dependencies.
fix
A solution to an existing bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Currently, the
next
branch's nightly builds fail due to its inability to compile thedashmap
crate. According to the GitHub Actions logs, it turns out that this is due to xacrimon/dashmap#133, where it was discovered thatserde
unexpectedly introduced a semver-breaking change in a patch release. A patch was quickly issued for[email protected]
.Now, this alone should fix the issue. Though, I would later find out while investigating the logs that
dashmap
had been pinned to4.0.0
. Looking at theCargo.toml
, Cargo should have pulled in the latest patch ofdashmap
(see the dependency declaration below).serenity/Cargo.toml
Lines 155 to 158 in 7e0b1d3
Indeed, this is the case except for nightly builds. I went through the Git blames and found that #1222 made it so that the nightly builds only pulled in the "minimal version" of dependencies. Details of this nightly feature may be found at rust-lang/cargo#4100. Attached below is the workflow configuration in question:
serenity/.github/workflows/ci.yml
Line 93 in 7e0b1d3
In effect, the invocation to
cargo update -Z minimal-versions
must have pinneddashmap
to the buggy4.0.0
, hence the compilation failures.Possible Courses of Action
cargo update -Z minimal-versions
so that CI will always pull in the latest semver-compatible dependencies.