Fixed string-delimiters, added Regex- and Itertools-crates, ... #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elimeter-typo to Delimiter across the library
arqunis
requested changes
Aug 13, 2017
src/lib.rs
Outdated
| @@ -128,6 +128,9 @@ extern crate tokio_core; | |||
| extern crate typemap; | |||
| #[cfg(feature = "gateway")] | |||
| extern crate websocket; | |||
| #[cfg(feature = "framework")] | |||
| extern crate regex; | |||
| extern crate itertools; | |||
hsiW
added
bug
arqunis
requested changes
Aug 13, 2017
src/framework/mod.rs
Outdated
|
|
||
| let regex = Regex::new(®ular_expression).unwrap(); | ||
|
|
||
| let mut result: Vec<String> = vec![]; |
There was a problem hiding this comment.
This and the for loop can be changed to
regex.split(content)
.filter_map(|p| if !p.is_empty() { Some(p.to_string()) } else { None })
.collect::<Vec<_>>()
src/framework/mod.rs
Outdated
| .map(|arg| arg.to_owned()) | ||
| .collect::<Vec<String>>() | ||
| let delimiters = &self.configuration.delimiters; | ||
| let regular_expression = delimiters.iter(). |
There was a problem hiding this comment.
It'd look better (or less awkward) if you put this dot on the same line as map.
arqunis
approved these changes
Aug 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... changed Delimeter-typo to Delimiter across the library