Implementing Cucumber Scenario. Exercise 1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakaleo
reviewed
Apr 22, 2021
| <artifactId>cucumber-java</artifactId> | ||
| <version>6.9.1</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Careful, you have this dependency twice - you only need the second one.
| public List<Order_NB> getUrgentOrders() { | ||
| List<Order_NB> results = new ArrayList<>(); | ||
| for(int i=0;i<receivedOrders.size();i++) { | ||
| if (receivedOrders.get(i).getOrderStatus()=="Urgent") |
There was a problem hiding this comment.
When comparing Strings in Java, don't forget to use the equals() method, e.g. if (receivedOrders.get(i).getOrderStatus().equals("Urgent"))
| break; | ||
| } | ||
| } | ||
| return receivedOrders.get(i).getOrderStatus(); |
There was a problem hiding this comment.
This is good but you'll learn easier ways to write this code later on in the course.
| public void sarah_should_see_the_order_in_her_order_history() { | ||
| assertThat(customer.getOrderHistoryFor(orderReceipt.getCustomerId())).contains(Order.matching(orderReceipt)); | ||
| } | ||
|
|
| } | ||
|
|
||
| public void completeOrder(OrderReceipt orderReceipt) { | ||
| coffeeOrders.getOrders().stream().filter(order -> order.getCustomerId()==orderReceipt.getCustomerId()) |
There was a problem hiding this comment.
This would work if customerId was a number, but if it is a string it is better to use equals()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wakaleo Ready For review