Fixed isAlive function to work with appium #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this PR
Fixed isAlive function to work with appium
Intended effect
It is possible that drover closed during test execution (some error for example). This function helps Serenity reinit driver in this case.
How should this be manually tested?
You can test with some other driver - firefox or chrome, for this you should create test class with multiple test cases (web tests), run it and after some of test opens browser - close it. Only current test should fail, other tests should be fine
Side effects
N/A
Documentation
If the pull request is user facing, how is it documented?
Are there examples of how to use the new behavior that users need to know about?
Relevant tickets
#408
Screenshots (if appropriate)
N/A