Pull request for adding log and auth wrappers for serenity-rest-assured #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
in #212 and #185 was reported about impossibility usage of log() and auth() and auntificate() methods of serenity-rest-assured
Reason:
We use enhancements of RequestSpecification methods to record calls of them. We "wrap" all method to be notified about it call, but during log and auth RequstSpecification returned without provided wrappers. This was not tested at all.
Solution:
Providing wrappers for AuthenticationSpecification and RequestLogSpecification to be sure that they will operate with enhancemened RequestSpecification. Also some tests are provided.