Pull requst for adding input streams closing. Please don't merge if not success #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YamStranger
changed the title
YamStranger
changed the title
wakaleo
added a commit
that referenced
this pull request
Nov 23, 2015
Pull requst for adding input streams closing. Please don't merge if not success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
During investigation for issue #160 I found a lot of places, where we should close streams properly. It can be reason of this issue, or not - I cant reproduce it.
Reason:
It seems that some resources are not deallocated in properly way.
Solution:
some try-catch-finally replaced by try-catch resources, also added closing resources during reading properties and zip files.