Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nickvergessen/more sensible default populating of counters #142

Merged

Conversation

serebrov
Copy link
Owner

@serebrov serebrov commented Nov 21, 2021

A change from #141 + fix frequently module tests.

@codecov-commenter
Copy link

Codecov Report

Merging #142 (792535c) into master (a1a708a) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   89.42%   89.67%   +0.25%     
==========================================
  Files          16       16              
  Lines         643      775     +132     
  Branches      133      144      +11     
==========================================
+ Hits          575      695     +120     
- Misses         62       75      +13     
+ Partials        6        5       -1     
Impacted Files Coverage Δ
src/utils/frequently.js 94.44% <100.00%> (+0.50%) ⬆️
src/components/anchors.vue 60.00% <0.00%> (-6.67%) ⬇️
src/utils/store.js 67.85% <0.00%> (-1.71%) ⬇️
src/components/Picker.vue 83.78% <0.00%> (-0.84%) ⬇️
src/utils/data.js 100.00% <0.00%> (ø)
src/utils/index.js 100.00% <0.00%> (ø)
src/components/Emoji.vue 100.00% <0.00%> (ø)
src/components/skins.vue 100.00% <0.00%> (ø)
src/components/search.vue 100.00% <0.00%> (ø)
src/utils/shared-props.js 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a708a...792535c. Read the comment docs.

@serebrov serebrov merged commit d0aba84 into master Nov 21, 2021
@serebrov serebrov deleted the nickvergessen/more-sensible-default-populating-of-counters branch November 21, 2021 17:22
@serebrov
Copy link
Owner Author

Published version 10.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants