Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing or making vue-virtual-scroller optional #52

Closed
serebrov opened this issue Jul 13, 2019 · 4 comments
Closed

Consider removing or making vue-virtual-scroller optional #52

serebrov opened this issue Jul 13, 2019 · 4 comments

Comments

@serebrov
Copy link
Owner

While vue-virtual-scroller helps getting some additional performance, it is not critical and component worked fast enough without it.
The disadvantage of the virtual scroller is that it adds complex HTML structure which is harder to customize (for example, it is complex to style the scroll bar).

@briancaffey
Copy link

I have come across this issue in trying to customize the height of the scroller. I'm finding strange behavior on mobile and sometimes on desktop browsers the categories are overlapping. @serebrov thanks

@apasov
Copy link

apasov commented Sep 19, 2019

@serebrov I support your idea. I described my situation in #57

@serebrov
Copy link
Owner Author

Related PR that adds virtual scroller - #20

serebrov added a commit that referenced this issue Sep 20, 2019
@serebrov
Copy link
Owner Author

serebrov commented Sep 20, 2019

@briancaffey @apasov I've just pushed version 6.1.1 to npm with new StaticPicker component - it is the same as Picker, but doesn't use the vue-virtual-scroller.

Updated the demo app, the "Custom Search And Preview Templates Example" example uses StaticPicker.

Also added related information to README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants