Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boxed interface visitors instead of constrained generics #159

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

agocke
Copy link
Collaborator

@agocke agocke commented Feb 20, 2024

Benchmarks showed that the generics weren't buying much, if anything, and the generics are much harder to use and read.

Allocations shouldn't be a large problem since the visitors are mostly stateless and can usually be singletons

@agocke agocke merged commit 2432515 into serdedotnet:main Feb 20, 2024
1 check passed
@agocke agocke deleted the visitor-ifaces branch February 20, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant