Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of unstable core::num::Zero, which was removed upstream. #899

Merged
merged 1 commit into from
Apr 23, 2017
Merged

Remove usage of unstable core::num::Zero, which was removed upstream. #899

merged 1 commit into from
Apr 23, 2017

Conversation

SimonSapin
Copy link
Contributor

rust-lang/rust#41437

Backport of #898 to 0.9.x

@dtolnay dtolnay merged commit 1a2b381 into serde-rs:v0.9 Apr 23, 2017
@SimonSapin SimonSapin deleted the z-is-dead-in-0.9-too branch April 23, 2017 23:44
@SimonSapin
Copy link
Contributor Author

I’ve realized that looking at each byte is incorrect for fat pointers (which can contain non-zero secondary component (length or vtable) but still have a null "data" component). But since Deserialize is not implemented for raw pointers anyway that ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonSapin @dtolnay