Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RUST_MIN_STACK if unset #503

Merged
merged 2 commits into from
Aug 18, 2016
Merged

Set RUST_MIN_STACK if unset #503

merged 2 commits into from
Aug 18, 2016

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Aug 18, 2016

No description provided.

@erickt
Copy link
Member

erickt commented Aug 18, 2016

@homu: r+ dba1377

homu added a commit that referenced this pull request Aug 18, 2016
Set RUST_MIN_STACK if unset
@dtolnay dtolnay merged commit 01f6115 into master Aug 18, 2016
@dtolnay dtolnay deleted the stack branch August 18, 2016 20:09
homu added a commit to serde-deprecated/syntex that referenced this pull request Aug 20, 2016
Add syntex::with_extra_stack helper

This is the same workaround from serde-rs/serde#503. I am adding it here because Servo just hit this with quasi_codegen (rust-lang/rust-bindgen#35) and I want to share the code. I will update the serde_codegen implementation to use this too.

Unfortunately we can't apply this to `syntex::Registry::expand` in general because rustc overflows its stack trying to decide whether `syntex::Registry` implements Send :panda_face:.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants