PhantomData<T> does not require bounds on T #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +79,13 @@ pub fn with_bound<F>( | |||
| } | |||
| impl visit::Visitor for FindTyParams { | |||
| fn visit_path(&mut self, path: &ast::Path, _id: ast::NodeId) { | |||
| if let Some(seg) = path.segments.last() { | |||
| if seg.identifier.name.as_str() == "PhantomData" { | |||
There was a problem hiding this comment.
While it's not great to implement a custom type called Phantom data, i think this should check the rest of the path, too.
There was a problem hiding this comment.
I don't think we always get the full path here... but I will try it.
There was a problem hiding this comment.
Oh..we're in the ast, i keep forgetting... Well, it's good enough :)
|
@homu r+ |
homu
added a commit
that referenced
this pull request
Jul 22, 2016
PhantomData<T> does not require bounds on T
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.