feat(codegen): Infer Default and Deserialize bounds correctly #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2016
|
awesome! |
Closed
rubdos
pushed a commit
to rubdos/serde
that referenced
this pull request
Jun 20, 2017
rational: Implement approximation from floats and FromPrimitive for v… …arious types FromPrimitive is implemented for i8/16/32/64 and BigInt. rust-num/num#282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the remaining part of #197 (following up on my previous PRs #260 and #265) by inferring a
T: Defaultbound for fields that (1) have#[serde(default)], or (2) have#[serde(skip_deserializing)]and not#[serde(default=...)]. I factored out the generics-building code from #260 to share it between ser and de.This PR also makes progress toward #259, although I have not attempted to resolve the
MapVisitor::missing_fieldproblem mentioned in that issue.