-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asserts for DeserializeSeed #2325
Conversation
44cf4d0
to
1316053
Compare
1316053
to
5e3b99d
Compare
5e3b99d
to
4b2e012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a usage example to the documentation of each of the new functions?
I'm not quite sure whether I would want to grow the API of serde_test in this way. The existing interface is already pretty clumsy and limited. But nothing in there is using any private internals of serde, so perhaps it would be best to let others experiment with different designs in a separate crate.
@dtolnay Sure, added.
Deserializer is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave this another look, and I think I would prefer not to have this in this crate.
Thanks anyway for the PR though!
I would be interested to see someone pursue a library for testing serde impls in a better way as a different crate.
Equivalent asserts that accept a seed to test stateful deserialization. Was requested in serde-rs/test#24.