logical operators for random select filters #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seraxis
requested changes
Dec 18, 2023
| if (this.getFilter().get(key) instanceof Integer) { | ||
| Integer value = (Integer)this.getFilter().get(key); | ||
| if (scoreData == null) { | ||
| if (0 != value) { |
There was a problem hiding this comment.
instead of doing this if you can return 0 != value directoly
There was a problem hiding this comment.
instead of doing this if you can
return 0 != valuedirectoly
I don't agree it would be the correct approach, as it would only make sense if entire style of this function would change from switch-like to independent branches, where each branch returns true or false by itself, without return true; in the end acting as default case. I could refactor it that way if you insist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A feature to add logical operators to random select filters, particularly for keys with integer values. Implements "<", ">", "<=", ">=" and "&&" operations.
Normally, beatoraja as of 0.8.6 allows for fixed value keys in random select filters, such as "clear": 6, which would select a song with Hard-Clear lamp. It isn't possible to have it select from a range of values, such as 4-5, which would describe all songs with lamp ranging from Easy-Clear to Groove-Clear. This PR allows doing it as such:
{ "name":"RANDOM EASY-GROOVE", "filter": { "clear": ">=4 && <6" } }This has no effect on normal beatoraja behavior, otherwise. Everything that would work in upstream still holds, it only expands on it.