🐞 Old PostgreSQL backups not being removed and rotated

Parent issue: sequentech/meta#309 WAL backups are not being removed and default backup config retains too many backups.
sequentech · Nov 5, 2023 · c0ddc65 · c0ddc65
1 parent 6be2f64
commit c0ddc65
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 7 deletions.
diff --git a/config.yml b/config.yml
@@ -50,7 +50,7 @@ config:
     # cron tab configuration for base backups
     base_backups:
       # number of days base backups are kept/stored (0 means forever)
-      keep_days: 30
+      keep_days: 15
       # day of the week that the job should run ( 0-6 for Sunday-Saturday, *, etc )
       weekday: '*'
       # Day of the month the job should run ( 1-31, *, */2, etc )

diff --git a/doc/devel/auth1.config.yml b/doc/devel/auth1.config.yml
@@ -51,7 +51,7 @@ config:
     # cron tab configuration for base backups
     base_backups:
       # number of days base backups are kept/stored (0 means forever)
-      keep_days: 30
+      keep_days: 15
       # day of the week that the job should run ( 0-6 for Sunday-Saturday, *, etc )
       weekday: '*'
       # Day of the month the job should run ( 1-31, *, */2, etc )

diff --git a/doc/devel/auth2.config.yml b/doc/devel/auth2.config.yml
@@ -51,7 +51,7 @@ config:
     # cron tab configuration for base backups
     base_backups:
       # number of days base backups are kept/stored (0 means forever)
-      keep_days: 30
+      keep_days: 15
       # day of the week that the job should run ( 0-6 for Sunday-Saturday, *, etc )
       weekday: '*'
       # Day of the month the job should run ( 1-31, *, */2, etc )

diff --git a/doc/devel/sequent.config.yml b/doc/devel/sequent.config.yml
@@ -51,7 +51,7 @@ config:
     # cron tab configuration for base backups
     base_backups:
       # number of days base backups are kept/stored (0 means forever)
-      keep_days: 30
+      keep_days: 15
       # day of the week that the job should run ( 0-6 for Sunday-Saturday, *, etc )
       weekday: '*'
       # Day of the month the job should run ( 1-31, *, */2, etc )

diff --git a/doc/production/config.auth.yml b/doc/production/config.auth.yml
@@ -51,7 +51,7 @@ config:
     # cron tab configuration for base backups
     base_backups:
       # number of days base backups are kept/stored (0 means forever)
-      keep_days: 30
+      keep_days: 15
       # day of the week that the job should run ( 0-6 for Sunday-Saturday, *, etc )
       weekday: '*'
       # Day of the month the job should run ( 1-31, *, */2, etc )

diff --git a/doc/production/config.master.yml b/doc/production/config.master.yml
@@ -51,7 +51,7 @@ config:
     # cron tab configuration for base backups
     base_backups:
       # number of days base backups are kept/stored (0 means forever)
-      keep_days: 30
+      keep_days: 15
       # day of the week that the job should run ( 0-6 for Sunday-Saturday, *, etc )
       weekday: '*'
       # Day of the month the job should run ( 1-31, *, */2, etc )

diff --git a/templates/clean_old_postgres_backups.sh b/templates/clean_old_postgres_backups.sh
@@ -31,6 +31,7 @@ DATE_OLDEST=`echo "$DATE_NOW - (24*3600*$KEEP_DAYS)" | bc`
 
 LIST_BASE=`ls $BACKUP_DIR/base`
 LIST_DUMP=`ls $BACKUP_DIR/dump`
+LIST_WAL=`ls $BACKUP_DIR/wal`
 
 for FNAME in $LIST_BASE
 do
@@ -62,4 +63,16 @@ do
   fi
 done
 
-exit 0
+for FNAME in $LIST_WAL
+do
+  # Get file's last modification time in seconds since the epoch
+  FDATE=`date -r "$BACKUP_DIR/wal/$FNAME" +%s`
+
+  # check date and remove if it's too old
+  if [ "$DATE_OLDEST" -gt "$FDATE" ]; then
+    echo "deleting $BACKUP_DIR/wal/$FNAME"
+    rm -f $BACKUP_DIR/wal/$FNAME
+  fi
+done
+
+exit 0