Improved documentation #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Defaults to `Sequelize.STRING` | ||
| columnType: new Sequelize.STRING(100) | ||
| } | ||
| ;(async () => { |
There was a problem hiding this comment.
Actually no, it is strictly mandatory. You can even test it to see it won't compile.
That's just a common pattern found in no-semicolon javascript coding style to force a proper understanding by the compiler in those very specific cases where we want to start a line with a column.
There was a problem hiding this comment.
Right, codebase is not using semi
sushantdhiman
approved these changes
Mar 5, 2020
|
This fantastic, thank you very much! Excellent!! |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a big change in the organization of the documentation. The story is that I lost quite a lot of time trying to understand how this project works and had to read directly the code in the end because I wasn't able to understand the current doc.
I kept most of it, re-organized it in a more logical way, provided a full working example and modernized a little the examples that already existed.