-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(documentation): explain custom/new postgres data types #10170
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10170 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 63 63
Lines 9420 9420
=======================================
Hits 9076 9076
Misses 344 344 Continue to review full report at Codecov.
|
I suggest create a new page called |
5354b42
to
f093930
Compare
That part is done. I did not find tests for documentation, if such a thing exists. I have just used grep to find a repair broken links. |
docs/data-types.md
Outdated
@@ -0,0 +1,332 @@ | |||
## Basic data types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Begin with # Datatypes
, so nav item is also named as Datatypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
f093930
to
938c874
Compare
Thanks @javiertury |
👍 I've been meaning to write something like this for ages! :) |
Pull Request check-list
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Issue #10114. I propose to document how to add custom data types. In this pull request I illustrate only how to add postgres data types.