[FIX] seqan3::views::single_pass_input::iterator::operator++(int) must return void (real cxx20 std::input_iterator) #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marehr
requested review from
a team and
MitraDarja
and removed request for
a team
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/D3Qk2REEawttzBfFdy48hzFR52Va |
Codecov Report
@@ Coverage Diff @@
## master #2775 +/- ##
==========================================
- Coverage 98.37% 98.37% -0.01%
==========================================
Files 272 272
Lines 10884 10881 -3
==========================================
- Hits 10707 10704 -3
Misses 177 177
Continue to review full report at Codecov.
|
MitraDarja
approved these changes
Aug 24, 2021
MitraDarja
requested review from
a team and
eseiler
and removed request for
a team
eseiler
approved these changes
Aug 24, 2021
…g iterator returns void
…ing iterator returns void
…t return void (real cxx20 std::input_iterator) https://github.com/rrahn/seqan3/blame/939bea75ab00f254ac0c172506f761a2ff6f51eb/include/seqan3/range/view/single_pass_input.hpp#L262-L272 added this change; it is broken, because the semantic of output_iterator can't be fulfilled `*it++ = value` should have the same semantic as `*i = value; ++i`, but it currently has `++i; *i = value`.
…st return void (real cxx20 std::input_iterator)
…st return void (real cxx20 std::input_iterator)
…st return void (real cxx20 std::input_iterator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.