-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] deprecate seqan3::views::move #2563
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/AHKAzFwKpS6B5UjhVxqEWs2a3sjs |
Codecov Report
@@ Coverage Diff @@
## master #2563 +/- ##
==========================================
- Coverage 98.23% 98.23% -0.01%
==========================================
Files 269 269
Lines 10549 10539 -10
==========================================
- Hits 10363 10353 -10
Misses 186 186
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but what about
| seqan3::views::move // mark ID to be moved out of record |
Snippets build because it is a snippet with a workaround that is always active on GCC
Ty good catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the SEQAN3_WORKAROUND_GCC_96070
workaround from sequence_file_solution3.cpp
resolve seqan/product_backlog#328