Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] deprecate seqan3::views::move #2563

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Conversation

marehr
Copy link
Member

@marehr marehr commented Apr 26, 2021

@marehr marehr requested review from a team and SGSSGene and removed request for a team April 26, 2021 22:25
@vercel
Copy link

vercel bot commented Apr 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/AHKAzFwKpS6B5UjhVxqEWs2a3sjs
✅ Preview: https://seqan3-git-fork-marehr-deprecatemove-seqan.vercel.app

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #2563 (4bc7c3e) into master (922b838) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 4bc7c3e differs from pull request most recent head 72acbe7. Consider uploading reports for the commit 72acbe7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2563      +/-   ##
==========================================
- Coverage   98.23%   98.23%   -0.01%     
==========================================
  Files         269      269              
  Lines       10549    10539      -10     
==========================================
- Hits        10363    10353      -10     
  Misses        186      186              
Impacted Files Coverage Δ
include/seqan3/range/views/move.hpp 100.00% <ø> (ø)
.../seqan3/range/container/concatenated_sequences.hpp 96.84% <0.00%> (-0.07%) ⬇️
include/seqan3/io/record.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/cigar/cigar.hpp 91.30% <0.00%> (ø)
include/seqan3/range/views/as_const.hpp 100.00% <0.00%> (ø)
include/seqan3/io/sam_file/format_bam.hpp 96.29% <0.00%> (ø)
include/seqan3/io/sam_file/format_sam.hpp 97.44% <0.00%> (ø)
include/seqan3/io/sequence_file/input.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/aminoacid/aa20.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/aminoacid/aa27.hpp 100.00% <0.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8afe8f...72acbe7. Read the comment docs.

Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SGSSGene SGSSGene requested review from a team and eseiler and removed request for a team April 27, 2021 15:59
Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but what about

| seqan3::views::move // mark ID to be moved out of record

Snippets build because it is a snippet with a workaround that is always active on GCC

@marehr
Copy link
Member Author

marehr commented Apr 28, 2021

Looks good, but what about

| seqan3::views::move // mark ID to be moved out of record

Snippets build because it is a snippet with a workaround that is always active on GCC

Ty good catch

Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the SEQAN3_WORKAROUND_GCC_96070 workaround from sequence_file_solution3.cpp

@eseiler eseiler enabled auto-merge (squash) April 29, 2021 08:59
@eseiler eseiler merged commit fd4ffb7 into seqan:master Apr 29, 2021
@marehr marehr deleted the deprecate_move branch April 29, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate seqan3::views::move
3 participants