[MISC] Replace `seqan3::views::join` with `seqan3::views::join_with` #2526

SGSSGene · 2021-04-19T17:31:01Z

Deprecates seqan3::views::join use seqan3::views::join_with or std::views::join instead.
Adds seqan3::views::join_with
Move files from seqan3/ranges/views/join.hpp to seqan3/utility/views/join_with.hpp

vercel · 2021-04-19T17:31:06Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/AkersZk3zyum66KFxu6EKy9wWbQ4
✅ Preview: https://seqan3-git-fork-sgssgene-deprecate-viewsjoin-seqan.vercel.app

codecov · 2021-04-19T18:12:59Z

Codecov Report

Merging #2526 (e963591) into master (9c9e01b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2526   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         270      270           
  Lines       10570    10570           
=======================================
  Hits        10384    10384           
  Misses        186      186

Impacted Files	Coverage Δ
include/seqan3/alphabet/views/translate_join.hpp	`100.00% <ø> (ø)`
include/seqan3/io/sequence_file/format_fasta.hpp	`98.68% <ø> (ø)`
.../seqan3/range/container/concatenated_sequences.hpp	`96.90% <ø> (ø)`
include/seqan3/argument_parser/validators.hpp	`91.39% <100.00%> (ø)`
include/seqan3/search/fm_index/fm_index.hpp	`100.00% <100.00%> (ø)`
include/seqan3/utility/views/interleave.hpp	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9e01b...e963591. Read the comment docs.

MitraDarja

LGTM, just one question. :)

test/performance/range/views/view_translate_2D_benchmark.cpp

SGSSGene · 2021-04-20T08:43:58Z

Rename file to "join_with_view.hpp"

marehr

thank you!

marehr · 2021-04-21T14:50:21Z

include/seqan3/range/container/concatenated_sequences.hpp

 #include <seqan3/range/views/repeat_n.hpp>
 #include <seqan3/range/views/slice.hpp>
+#include <seqan3/utility/views/join_with.hpp>


Is this even used in this class?

I was cold. Needed my computer to heat up ;-)
Yes, not needed at all, no clue why I added it.

marehr · 2021-04-21T14:50:32Z

include/seqan3/io/sequence_file/format_fasta.hpp

 #include <seqan3/utility/char_operations/predicate.hpp>
 #include <seqan3/utility/detail/type_name_as_string.hpp>
+#include <seqan3/utility/views/join_with.hpp>


Is this even used in this class?

marehr · 2021-04-21T14:53:14Z

include/seqan3/range/views/join.hpp

-using ::ranges::views::join;
-
-} // namespace seqan3::views
+SEQAN3_DEPRECATED_HEADER(


EDIT: never mind, see second post

Suggested change

SEQAN3_DEPRECATED_HEADER(

namespace seqan3::views

{

/*!\brief A join view.

* \ingroup views

* \deprecated Please use std::views::join or seqan3::views::join_with (if a separator is needed)

*/

SEQAN3_DEPRECATED_310 inline constexpr auto join = ::ranges::views::join;

} // namespace seqan3::views

SEQAN3_DEPRECATED_HEADER(

On second thought, your initial solution might be better in this case.

as we can deprecate seqan3/range/views/join.hpp and

don't use that internally any more

seqan3/range/views/all.hpp includes seqan3/utility/views/join_with.hpp and thus exposes the deprecated seqan3::views::join

that means everything compiles as before, using all.hpp will not throw any warnings. an explicit include will give a proper deprecation warning.

include/seqan3/utility/views/join_with.hpp

marehr · 2021-05-04T10:52:13Z

@SGSSGene I'll rebase this for you :)

- Deprecates `seqan3::views::join` use `seqan3::views::join_with` or `std::views::join` instead. - Adds `seqan3::views::join_with` - Move files from seqan3/ranges/views/join.hpp to seqan3/utility/views/join_with.hpp

vercel bot temporarily deployed to Preview April 19, 2021 17:31 Inactive

SGSSGene force-pushed the deprecate/views_join branch 2 times, most recently from 75cbfec to 6cc9cbb Compare April 19, 2021 17:42

vercel bot temporarily deployed to Preview April 19, 2021 17:43 Inactive

SGSSGene requested review from a team and MitraDarja and removed request for a team April 19, 2021 18:16

MitraDarja requested changes Apr 20, 2021

View reviewed changes

test/performance/range/views/view_translate_2D_benchmark.cpp Outdated Show resolved Hide resolved

SGSSGene force-pushed the deprecate/views_join branch from 6cc9cbb to 0210902 Compare April 21, 2021 10:31

vercel bot temporarily deployed to Preview April 21, 2021 10:31 Inactive

SGSSGene requested a review from MitraDarja April 21, 2021 11:11

MitraDarja approved these changes Apr 21, 2021

View reviewed changes

MitraDarja requested review from a team and marehr and removed request for a team April 21, 2021 14:46

marehr reviewed Apr 21, 2021

View reviewed changes

SGSSGene force-pushed the deprecate/views_join branch from 0210902 to dda55c7 Compare April 21, 2021 16:34

vercel bot temporarily deployed to Preview April 21, 2021 16:34 Inactive

SGSSGene requested a review from marehr April 21, 2021 16:35

marehr approved these changes Apr 21, 2021

View reviewed changes

marehr enabled auto-merge April 21, 2021 16:38

SGSSGene mentioned this pull request May 4, 2021

[FIX] gcc-10: missing RANGES_DEEP_STL_INTEGRATION #2582

Merged

SGSSGene added 2 commits May 4, 2021 13:06

[MISC] Replace seqan3::views::join with seqan3::views::join_with

177b65c

- Deprecates `seqan3::views::join` use `seqan3::views::join_with` or `std::views::join` instead. - Adds `seqan3::views::join_with` - Move files from seqan3/ranges/views/join.hpp to seqan3/utility/views/join_with.hpp

[FIX] reorder of some includes

e963591

marehr force-pushed the deprecate/views_join branch from dda55c7 to e963591 Compare May 4, 2021 11:08

vercel bot temporarily deployed to Preview May 4, 2021 11:09 Inactive

marehr merged commit 9544a58 into seqan:master May 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MISC] Replace `seqan3::views::join` with `seqan3::views::join_with` #2526

[MISC] Replace `seqan3::views::join` with `seqan3::views::join_with` #2526

SGSSGene commented Apr 19, 2021 •

edited by marehr

Loading

vercel bot commented Apr 19, 2021 •

edited

Loading

codecov bot commented Apr 19, 2021 •

edited

Loading

MitraDarja left a comment

SGSSGene commented Apr 20, 2021

marehr left a comment

marehr Apr 21, 2021

SGSSGene Apr 21, 2021

marehr Apr 21, 2021

marehr Apr 21, 2021 •

edited

Loading

marehr Apr 21, 2021 •

edited

Loading

marehr commented May 4, 2021

[MISC] Replace seqan3::views::join with seqan3::views::join_with #2526

[MISC] Replace seqan3::views::join with seqan3::views::join_with #2526

Conversation

SGSSGene commented Apr 19, 2021 • edited by marehr Loading

vercel bot commented Apr 19, 2021 • edited Loading

codecov bot commented Apr 19, 2021 • edited Loading

Codecov Report

MitraDarja left a comment

Choose a reason for hiding this comment

SGSSGene commented Apr 20, 2021

marehr left a comment

Choose a reason for hiding this comment

marehr Apr 21, 2021

Choose a reason for hiding this comment

SGSSGene Apr 21, 2021

Choose a reason for hiding this comment

marehr Apr 21, 2021

Choose a reason for hiding this comment

marehr Apr 21, 2021 • edited Loading

Choose a reason for hiding this comment

marehr Apr 21, 2021 • edited Loading

Choose a reason for hiding this comment

marehr commented May 4, 2021

[MISC] Replace `seqan3::views::join` with `seqan3::views::join_with` #2526

[MISC] Replace `seqan3::views::join` with `seqan3::views::join_with` #2526

SGSSGene commented Apr 19, 2021 •

edited by marehr

Loading

vercel bot commented Apr 19, 2021 •

edited

Loading

codecov bot commented Apr 19, 2021 •

edited

Loading

marehr Apr 21, 2021 •

edited

Loading

marehr Apr 21, 2021 •

edited

Loading