Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] Alphabet: rename sam_dna16 to dna16sam #2521

Merged
merged 6 commits into from
Apr 20, 2021
Merged

[MISC] Alphabet: rename sam_dna16 to dna16sam #2521

merged 6 commits into from
Apr 20, 2021

Conversation

Irallia
Copy link
Contributor

@Irallia Irallia commented Apr 19, 2021

@Irallia Irallia self-assigned this Apr 19, 2021
@vercel
Copy link

vercel bot commented Apr 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/H7hPn3aR7vCQFtV1zXZSG8FrYeSL
✅ Preview: https://seqan3-git-fork-irallia-misc-alphabetrenamesamdn-16138f.vercel.app

@Irallia Irallia force-pushed the misc/alphabet/rename_sam_dna16_to_dna16sam branch from 503cbed to fa2a44c Compare April 19, 2021 10:39
@codecov
Copy link

codecov bot commented Apr 19, 2021 •
edited
Loading

Codecov Report

Merging #2521 (a9df50f) into master (92e5067) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2521   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files         269      269           
  Lines       10521    10521           
=======================================
  Hits        10334    10334           
  Misses        187      187
Impacted Files Coverage Δ
include/seqan3/alphabet/nucleotide/dna16sam.hpp 100.00% <100.00%> (ø)
include/seqan3/io/sam_file/format_bam.hpp 96.21% <100.00%> (ø)
include/seqan3/range/views/drop.hpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e5067...a9df50f. Read the comment docs.

@marehr marehr requested review from a team and SGSSGene and removed request for a team April 19, 2021 13:10
@Irallia Irallia force-pushed the misc/alphabet/rename_sam_dna16_to_dna16sam branch from fa2a44c to f2ec1a2 Compare April 19, 2021 15:21
SGSSGene
SGSSGene requested changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  • CHANGLELOG.md is missing a PR-number
  • maybe you can change the title of the last commit? It currently says TODO: [MISC] rename seqan3::sam_dna16 to seqan3::dna16sam

CHANGELOG.md Outdated
@@ -32,6 +32,8 @@ If possible, provide tooling that performs the changes, e.g. a shell-script.

* Added `seqan3::phred94`, a quality type that represents the full Phred Score range (Sanger format) and is used for
PacBio Phred scores of HiFi reads ([\#2290](https://github.com/seqan/seqan3/pull/2290)).
* Deprecated `seqan3::sam_dna16`. Use `seqan3::dna16sam` instead.
([\#...](https://github.com/seqan/seqan3/pull/2521)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request number is missing

Suggested change
([\#...](https://github.com/seqan/seqan3/pull/2521)).
([\#2521](https://github.com/seqan/seqan3/pull/2521)).

@Irallia Irallia force-pushed the misc/alphabet/rename_sam_dna16_to_dna16sam branch from f2ec1a2 to cbffe5d Compare April 20, 2021 09:53
@Irallia
[DOC] Add changelog entry
c272c0f 
Signed-off-by: Lydia Buntrock <[email protected]>
SGSSGene
SGSSGene approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :-)

@Irallia Irallia force-pushed the misc/alphabet/rename_sam_dna16_to_dna16sam branch from cbffe5d to c272c0f Compare April 20, 2021 09:57
@SGSSGene SGSSGene requested review from a team and marehr and removed request for a team April 20, 2021 09:57
@marehr marehr enabled auto-merge (squash) April 20, 2021 11:33
@Irallia
Copy link
Contributor Author

Irallia commented Apr 20, 2021 •
edited
Loading

@eseiler wanted to move my changelog entry to api here #2522 (comment) so I moved it here aswell. As you moved it back, where is the difference?
@marehr

@marehr
Copy link
Member

marehr commented Apr 20, 2021 •
edited
Loading

@eseiler wanted to move my changelog entry to api here #2522 (comment) so I moved it here aswell. As you moved it back, where is the difference?
@marehr

You put the changelog entry in the wrong subsection. This belongs in API change / alphabet. I guess that you put in the other comment the whole changelog entry in the wrong first-level section (e.g. New features, Notable Bug-fixes or so).

@Irallia
Copy link
Contributor Author

Irallia commented Apr 20, 2021

@eseiler wanted to move my changelog entry to api here #2522 (comment) so I moved it here aswell. As you moved it back, where is the difference?
@marehr

You put the changelog entry in the wrong subsection. This belongs in API change / alphabet. I guess that you put in the other comment the whole changelog entry in the wrong first-level section (e.g. New features, Notable Bug-fixes or so).

AAAh I see, thank you!

@marehr marehr merged commit 85b8c5d into seqan:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGSSGene SGSSGene SGSSGene approved these changes

@marehr marehr marehr approved these changes

Assignees

@Irallia Irallia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename seqan3::sam_dna16 to seqan3::dna16sam
3 participants
@Irallia @marehr @SGSSGene