Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dash usable for subcommand #2306

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Make dash usable for subcommand #2306

merged 2 commits into from
Dec 17, 2020

Conversation

MitraDarja
Copy link
Contributor

@MitraDarja MitraDarja requested review from a team and eseiler and removed request for a team December 15, 2020 15:36
@codecov
Copy link

codecov bot commented Dec 15, 2020 •
edited
Loading

Codecov Report

Merging #2306 (03469d4) into master (da07f10) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2306   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         262      262           
  Lines       10853    10853           
=======================================
  Hits        10657    10657           
  Misses        196      196
Impacted Files Coverage Δ
include/seqan3/argument_parser/argument_parser.hpp 98.77% <100.00%> (ø)
...de/seqan3/argument_parser/detail/version_check.hpp 92.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da07f10...03469d4. Read the comment docs.

eseiler
eseiler requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

CHANGELOG.md Outdated Show resolved Hide resolved
test/unit/argument_parser/format_parse_test.cpp Outdated Show resolved Hide resolved
eseiler
eseiler approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't catch the missing braces in the first round. You can directly assign a second reviewer once done

include/seqan3/argument_parser/argument_parser.hpp Outdated Show resolved Hide resolved
@MitraDarja MitraDarja requested review from a team and smehringer and removed request for a team December 16, 2020 11:36
smehringer
smehringer approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@smehringer smehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@smehringer smehringer merged commit f048ef6 into seqan:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseiler eseiler eseiler approved these changes

@smehringer smehringer smehringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Argument Parser] Remove restriction for - in subparser app name
3 participants
@MitraDarja @smehringer @eseiler