Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] rename align_cfg::scoring to align_cfg::scoring_scheme #2027

Merged
merged 1 commit into from
Aug 19, 2020
Merged

[MISC] rename align_cfg::scoring to align_cfg::scoring_scheme #2027

merged 1 commit into from
Aug 19, 2020

Conversation

wvdtoorn
Copy link
Contributor

@wvdtoorn wvdtoorn requested review from a team and joergi-w and removed request for a team August 12, 2020 11:40
joergi-w
joergi-w requested changes Aug 13, 2020
View reviewed changes
Copy link
Member

@joergi-w joergi-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thank you! I found only some style errors.

And what becomes a bit confusing/unintuitive is the distinction:

  • seqan3::scoring_scheme is a concept
  • seqan3::align_cfg::scoring_scheme is a class template for types that model seqan3::scoring_scheme.

test/performance/alignment/global_affine_alignment_benchmark.cpp Outdated Show resolved Hide resolved
test/performance/alignment/global_affine_alignment_parallel_benchmark.cpp Outdated Show resolved Hide resolved
test/performance/alignment/global_affine_alignment_simd_benchmark.cpp Outdated Show resolved Hide resolved
test/performance/io/format_sam_benchmark.cpp Outdated Show resolved Hide resolved
test/unit/alignment/pairwise/fixture/global_affine_banded.hpp Outdated Show resolved Hide resolved
test/unit/alignment/pairwise/fixture/local_affine_banded.hpp Show resolved Hide resolved
test/unit/alignment/pairwise/fixture/local_affine_unbanded.hpp Show resolved Hide resolved
test/unit/alignment/pairwise/fixture/semi_global_affine_banded.hpp Show resolved Hide resolved
test/unit/alignment/pairwise/fixture/semi_global_affine_unbanded.hpp Show resolved Hide resolved
test/unit/alignment/pairwise/semi_global_affine_banded_test.cpp Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 13, 2020 •
edited
Loading

Codecov Report

Merging #2027 into release-3.0.2 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-3.0.2    #2027   +/-   ##
==============================================
  Coverage          97.89%   97.89%           
==============================================
  Files                263      263           
  Lines               9879     9879           
==============================================
  Hits                9671     9671           
  Misses               208      208
Impacted Files Coverage Δ
...e/seqan3/alignment/pairwise/detail/type_traits.hpp 100.00% <ø> (ø)
.../seqan3/alignment/pairwise/alignment_algorithm.hpp 98.50% <100.00%> (ø)
...qan3/alignment/pairwise/alignment_configurator.hpp 100.00% <100.00%> (ø)
...lignment/pairwise/detail/policy_scoring_scheme.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89df8c8...856c9f8. Read the comment docs.

@wvdtoorn wvdtoorn requested a review from joergi-w August 13, 2020 19:41
@wvdtoorn
Copy link
Contributor Author

wvdtoorn commented Aug 13, 2020 •
edited
Loading

@joergi-w thank you for pointing all the files out, I'm sorry to have overlooked the indentation shifts.
As for the naming concerns, that is a good observation (@seqan/core).

joergi-w
joergi-w approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@joergi-w joergi-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@joergi-w joergi-w requested review from a team and smehringer and removed request for a team August 14, 2020 05:44
@rrahn
Copy link
Contributor

rrahn commented Aug 14, 2020

We need to rename the scoring_scheme concept to scoring_scheme_for in order to reflect the concept naming rules of the standard. The rational is that scoring_scheme_for requires an additional type to check for. So I think we can keep the align_cfg naming as is.

@rrahn rrahn mentioned this pull request Aug 14, 2020
Closed
9 tasks
@wvdtoorn
Copy link
Contributor Author

Rebased as requested to avoid some mess with the align_cfg::detail namespace (#2020), and cleaned up the commit history.

smehringer
smehringer approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@smehringer smehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@smehringer smehringer merged commit 096c27e into seqan:release-3.0.2 Aug 19, 2020
@wvdtoorn wvdtoorn mentioned this pull request Aug 19, 2020
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smehringer smehringer smehringer approved these changes

@joergi-w joergi-w joergi-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wvdtoorn @rrahn @joergi-w @smehringer