[FIX] Prohibit long-option value pairs without a separation. #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smehringer
requested review from
a team and
eseiler
and removed request for
a team
eseiler
requested changes
May 7, 2020
|
And also please add a changelog entry |
Codecov Report
@@ Coverage Diff @@
## master #1792 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 247 247
Lines 9401 9401
=======================================
Hits 9167 9167
Misses 234 234
Continue to review full report at Codecov.
|
eseiler
requested changes
May 7, 2020
eseiler
approved these changes
May 7, 2020
smehringer
force-pushed
the
argument_parser_option_is_set
branch
from
9ea67f9
to
e3ff068
Compare
rrahn
requested changes
May 11, 2020
rrahn
approved these changes
May 14, 2020
smehringer
force-pushed
the
argument_parser_option_is_set
branch
from
d5a0fe0
to
e97ad03
Compare
For example, given the long option name "--opt", then "--optValue" was possible. This caused ambiguities if one long option name is the prefix of another. We now only allow "--opt Value" and "--opt=value".
smehringer
force-pushed
the
argument_parser_option_is_set
branch
from
e97ad03
to
96b9349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, given the long option name "--opt", then "--optValue" was
possible. This caused ambiguities if one long option name is the prefix
of another. We now only allow "--opt Value" and "--opt=value".
Fixes #1544