Feature/minimizer view #1654
Merged
Feature/minimizer view #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 241 241
Lines 9226 9226
=======================================
Hits 8997 8997
Misses 229 229 Continue to review full report at Codecov.
|
MitraDarja
force-pushed
the
feature/minimizer_view
branch
from
82a993c
to
b2c26af
Compare
MitraDarja
requested review from
a team,
wvdtoorn,
eseiler,
simonsasse and
joergi-w
and removed request for
a team,
wvdtoorn,
eseiler and
simonsasse
joergi-w
requested changes
Apr 6, 2020
joergi-w
requested changes
Apr 7, 2020
MitraDarja
force-pushed
the
feature/minimizer_view
branch
from
58a731c
to
4e8b34d
Compare
joergi-w
requested changes
Apr 7, 2020
There was a problem hiding this comment.
Sorry, I was not clear enough about the following detail: size_t is a type, while std::integral is a concept, which is satisfied by any type that represents integral numbers (including size_t). In SeqAn3 we have the terminology: be of a type, model a concept. Therefore, I need to ask you for the following changes before I can approve:
|
You have doxygen warnings for doc_dev_test: |
joergi-w
reviewed
Apr 7, 2020
Merged
MitraDarja
force-pushed
the
feature/minimizer_view
branch
from
556a69b
to
0f7068a
Compare
|
@smehringer Can you merge this? 😃 |
rrahn
pushed a commit
to rrahn/seqan3
that referenced
this pull request
May 6, 2020
* [Feature ] Add minimizer view Co-authored-by: Mitra Darja Darvish <[email protected]> Co-authored-by: smehringer <[email protected]>
MitraDarja
added a commit
to MitraDarja/seqan3
that referenced
this pull request
May 12, 2020
* [Feature ] Add minimizer view Co-authored-by: Mitra Darja Darvish <[email protected]> Co-authored-by: smehringer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the minimiser view without looking at the reverse strand (will be a seperate PR).
blocked by #1756