[SEARCH] Refactor search mode config to individual config elements #1639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1639 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 248 248
Lines 9436 9436
=======================================
Hits 9202 9202
Misses 234 234
Continue to review full report at Codecov.
|
smehringer
force-pushed
the
search_feature
branch
4 times, most recently
from
14bb7ae
to
20faa11
Compare
|
Since I changed a lot after the design decision, @eseiler Can you review again? It feels like cheeting if I take the approval as is. |
include/seqan3/search/detail/unidirectional_search_algorithm.hpp
Outdated
Show resolved
Hide resolved
smehringer
force-pushed
the
search_feature
branch
from
76baa44
to
eb54ff2
Compare
There was a problem hiding this comment.
Looks in general fine. Some minor changes to avoid copy'n'paste errors (I am not sure if you can copy the brief from the detail though, but at least the other way around should work.)
And I would try to be sparse with the word mode as it can be basically anything. So there are some suggestions to use another term.
| using detail::strong_type<uint8_t, strata, detail::strong_type_skill::convert>::strong_type; | ||
| //!\privatesection | ||
| //!\brief Internal id to check for consistent configuration settings. | ||
| static constexpr detail::search_config_id id{detail::search_config_id::mode}; | ||
| }; | ||
|
|
||
| /*!\brief Configuration element to determine the search mode. |
There was a problem hiding this comment.
Please update the documentation.
|
I somehow forgot the dynamic selector will be called |
|
looks like you forgot to update the search configuration cmakelists after renaming the test files: CMake Error at /home/travis/build/seqan/seqan3/test/coverage/CMakeLists.txt:84 (add_executable):
Cannot find source file:
mode_test.cpp
Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
.hxx .in .txx
Call Stack (most recent call first):
/home/travis/build/seqan/seqan3/test/unit/search/configuration/CMakeLists.txt:1 (seqan3_test) |
smehringer
force-pushed
the
search_feature
branch
from
8a3c1f0
to
5264f6c
Compare
The search modes were renamed and can now be used as individual config elements.
Since this is orthogonal to the non-dynamic config element
search_cfg::mode, mode was removed here. A follow-up PR will introduce thesearch_cfg::modeconfig element again as a dynamic selector.Resolves seqan/product_backlog#65