Misc/remove char type from file #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1400 +/- ##
==========================================
+ Coverage 97.53% 97.54% +<.01%
==========================================
Files 229 231 +2
Lines 8735 8747 +12
==========================================
+ Hits 8520 8532 +12
Misses 215 215
Continue to review full report at Codecov.
|
joergi-w
requested changes
Dec 6, 2019
joergi-w
approved these changes
Dec 6, 2019
rrahn
force-pushed
the
misc/remove_char_type_from_file
branch
from
1b3a3fa
to
751fa98
Compare
smehringer
requested changes
Dec 9, 2019
rrahn
force-pushed
the
misc/remove_char_type_from_file
branch
2 times, most recently
from
fc22e1f
to
5768afb
Compare
smehringer
reviewed
Dec 11, 2019
| typename tag_dict_type, | ||
| typename e_value_type, | ||
| typename bit_score_type> | ||
| void read_alignment_record(stream_type & stream, |
There was a problem hiding this comment.
Can you replace this at least with
template <typename arg_types...>
void read_alignment_record(arg_types ...args)
{ // ...
}? We do enough concept checks to enforce the proper parameters?
rrahn
force-pushed
the
misc/remove_char_type_from_file
branch
from
5768afb
to
d5af8a7
Compare
smehringer
requested changes
Dec 12, 2019
| @@ -829,61 +833,56 @@ class alignment_file_output | |||
| /*!\brief Deduces selected_field_ids from input and sets alignment_file_output::ref_ids_type to | |||
| * seqan3::detail::ref_info_not_given. Valid formats and stream_char_type are defaulted. | |||
There was a problem hiding this comment.
You forgot to adapt the documentation in this file
rrahn
force-pushed
the
misc/remove_char_type_from_file
branch
from
d5af8a7
to
8ee5ae1
Compare
|
travis still fails |
rrahn
force-pushed
the
misc/remove_char_type_from_file
branch
from
8ee5ae1
to
3c05f51
Compare
Documentation was broken due to the last changes. Is not fixed. I'll merge when it run through |
smehringer
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1399
Removes the char type from the files.
It also fixes the file exposer which caused hard fails in the format concept checks due to the using statement to import the read/write interfaces for the different file formats. The problem here is that for types that are not formats the using declaration causes compiler errors, which are different from not finding an viable overload. This was first visible when the char type was removed. Also I am not quite sure why?
Strangely, the exposer were not documented nor excluded from documentation but doxygen didn't trigger a warning. Not sure why? But I added the documentation for them as well.
A changelog will be added soon as well.
I also need to check at which places the documentation explicitly refers to the char type. There were three snippets that used it.