[FIX] fix detection of pthread on some linuxes #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that apparently the FindThreads.cmake has a bug where it prints stuff, even if told to be quiet. I have reported it: (purely cosmetic) |
Codecov Report
@@ Coverage Diff @@
## master #1200 +/- ##
=======================================
Coverage 96.73% 96.73%
=======================================
Files 210 210
Lines 7975 7975
=======================================
Hits 7715 7715
Misses 260 260Continue to review full report at Codecov.
|
h-2
force-pushed
the
fix/threading_issues
branch
from
d05311f
to
b9ba668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1193 #1199
It's strange that we didn't see this earlier. I know that for macOS we don't need to explicitly add it. Apparently FreeBSD also doesn't need it, but we should have seen this on Debian, or not? Maybe not all Linuxes are affected. In any case, the proposed fix is the recommended way of doing it with CMake nowadays.