Distance/Similarity #475
Merged
Distance/Similarity #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepandhaghighi
requested review from
sadrasabouri and
alirezazolanvari
and removed request for
sadrasabouri
sadrasabouri
reviewed
Jan 4, 2023
Document/Distance.ipynb
Outdated
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "cm = ConfusionMatrix(matrix = {0: {0: 3, 1: 0, 2: 0}, 1: {0: 0, 1: 1, 2: 2}, 2: {0: 2, 1: 1, 2: 3}})" |
There was a problem hiding this comment.
Can we use this, instead?
cm = ConfusionMatrix(matrix={0: {0: 3, 1: 0, 2: 0}, 1: {0: 0, 1: 1, 2: 2}, 2: {0: 2, 1: 1, 2: 3}})
Document/Distance.ipynb
Outdated
| } | ||
| ], | ||
| "source": [ | ||
| "cm.distance(metric = DistanceType.AMPLE)" |
There was a problem hiding this comment.
Can we use this, instead?
cm.distance(metric=DistanceType.AMPLE)
alirezazolanvari
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#349 #350
What does this implement/fix? Explain your changes.
distancemethod addedAny other comments?