Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme #445

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Readme #445

merged 3 commits into from
Aug 11, 2022

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • README.md modified

Any other comments?

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #445 (40c60ed) into dev (3427a21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #445   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          11       11           
  Lines        2434     2434           
  Branches      396      396           
=======================================
  Hits         2416     2416           
  Misses          6        6           
  Partials       12       12           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
It's much better now.

Copy link
Collaborator

@alirezazolanvari alirezazolanvari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks way better now!
Just a minor comment about the labels of the PR. I think this PR is not related to the NLnet.
BTW, great job. LGTM🚀

@sepandhaghighi
Copy link
Owner Author

@alirezazolanvari

You are right 💯
Fixed!

If everything is okay, Squash/Merge it after approval 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants