-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize code #251
Modernize code #251
Conversation
eumiro
commented
Jul 20, 2023
- Remove useless default encoding for source files (UTF-8 is the default)
- Simplify loops and conditions
Codecov Report
@@ Coverage Diff @@
## dev #251 +/- ##
==========================================
- Coverage 99.84% 99.84% -0.00%
==========================================
Files 7 7
Lines 1185 1181 -4
Branches 79 80 +1
==========================================
- Hits 1183 1179 -4
Misses 1 1
Partials 1 1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eumiro Well done 💯
Please take a look at my comment about default encoding and also:
- Update
CHANGELOG.md
- Update
AUTHORS.md
Thank you for the feedback, @sepandhaghighi. Dropped the commit with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀