Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize code #251

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Modernize code #251

merged 2 commits into from
Jul 24, 2023

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Jul 20, 2023

  1. Remove useless default encoding for source files (UTF-8 is the default)
  2. Simplify loops and conditions

@sepandhaghighi sepandhaghighi added this to the art 6.1 milestone Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #251 (b24f9ce) into dev (292b5aa) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #251      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.00%     
==========================================
  Files           7        7              
  Lines        1185     1181       -4     
  Branches       79       80       +1     
==========================================
- Hits         1183     1179       -4     
  Misses          1        1              
  Partials        1        1
Impacted Files Coverage Δ
art/art_param.py 100.00% <ø> (ø)
art/art.py 99.28% <100.00%> (-0.01%) ⬇️

sepandhaghighi
sepandhaghighi requested changes Jul 20, 2023
View reviewed changes
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eumiro Well done 💯

Please take a look at my comment about default encoding and also:

  1. Update CHANGELOG.md
  2. Update AUTHORS.md

art/__init__.py Outdated Show resolved Hide resolved
@eumiro
Copy link
Contributor Author

eumiro commented Jul 21, 2023

Thank you for the feedback, @sepandhaghighi. Dropped the commit with the coding removal and updated AUTHORS.md. The other commit is a pure refactoring, so it does not really make sense to add it to CHANGELOG.md. It does not change any functionality of the code.

sadrasabouri
sadrasabouri approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sepandhaghighi
sepandhaghighi approved these changes Jul 24, 2023
View reviewed changes
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sepandhaghighi sepandhaghighi merged commit 7073f02 into sepandhaghighi:dev Jul 24, 2023
23 checks passed
@eumiro eumiro deleted the modernize branch July 30, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

@sadrasabouri sadrasabouri sadrasabouri approved these changes

Assignees

@eumiro eumiro

Labels
enhancement
Projects
None yet
Milestone
art 6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@eumiro @sepandhaghighi @sadrasabouri