Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Test Error Fix #176

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Random Test Error Fix #176

merged 3 commits into from
Sep 3, 2021

Conversation

sadrasabouri
Copy link
Collaborator

Reference Issues/PRs

#175

What does this implement/fix? Explain your changes.

Instead of using just test string we used a more complete test for these situations like the sentence which font_wizard.py recommend:

abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~0123456789

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #176 (3cbb339) into dev (e38ce37) will decrease coverage by 2.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #176      +/-   ##
==========================================
- Coverage   90.95%   88.77%   -2.17%     
==========================================
  Files           1        1              
  Lines         276      276              
  Branches       75       75              
==========================================
- Hits          251      245       -6     
- Misses         23       26       +3     
- Partials        2        5       +3     
Impacted Files Coverage Δ
art/art.py 88.77% <0.00%> (-2.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38ce37...3cbb339. Read the comment docs.

@sadrasabouri
Copy link
Collaborator Author

@sepandhaghighi I can not find out why CodCov is failing 😕

@sepandhaghighi
Copy link
Owner

@sepandhaghighi I can not find out why CodCov is failing 😕

It's a bit weird!!
let me take a deeper look.

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sepandhaghighi sepandhaghighi merged commit ba26f90 into dev Sep 3, 2021
@sepandhaghighi sepandhaghighi deleted the random_test_error branch September 3, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants