Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greetings.yml Removed. #174

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Greetings.yml Removed. #174

merged 2 commits into from
Sep 2, 2021

Conversation

sadrasabouri
Copy link
Collaborator

@sadrasabouri sadrasabouri commented Sep 2, 2021

Reference Issues/PRs

Due to some issues we encountered in #172 according to new PR greetings we decided not to feature greetings.yml anymore.

What does this implement/fix? Explain your changes.

  • greetings.yml removed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #174 (957b78f) into dev (12a7aee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #174   +/-   ##
=======================================
  Coverage   90.95%   90.95%           
=======================================
  Files           1        1           
  Lines         276      276           
  Branches       75       75           
=======================================
  Hits          251      251           
  Misses         23       23           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a7aee...957b78f. Read the comment docs.

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sepandhaghighi sepandhaghighi merged commit e38ce37 into dev Sep 2, 2021
@sepandhaghighi sepandhaghighi deleted the remove_greetings branch September 2, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants