Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I love this repo #26

Closed
izaakf opened this issue Jul 19, 2019 · 12 comments
Closed

I love this repo #26

izaakf opened this issue Jul 19, 2019 · 12 comments

Comments

@izaakf
Copy link

izaakf commented Jul 19, 2019

No description provided.

@kennethreitz
Copy link
Collaborator

@izaakf you may kindly fuck yourself?

@izaakf izaakf changed the title this is stupid I love this repo Jul 19, 2019
@izaakf izaakf closed this as completed Jul 19, 2019
@franciscolourenco
Copy link

@izaakf could you please elaborate?

@izaakf
Copy link
Author

izaakf commented Oct 17, 2022

@izaakf could you please elaborate?

what would you like me to elaborate on? I feel this is rather clear.

@franciscolourenco
Copy link

franciscolourenco commented Oct 17, 2022

Just wanted to know why you thought think repo was stupid. Since then I've found out that virtualenv now also provides a fish activation script, and I've settled for a different solution, so I don't care anymore.

Here is it in case anyone else is interested:

    #~/.config/fish/config.fish

    # python virtualenv auto load when changing directory.
    # note: this assumes a virtualenv was created and stored in the project directory with: `virtualenv .venv`
    function auto_virtualenv --on-variable PWD
        if test -d ".venv"
            if not set -q VIRTUAL_ENV
                set --export --global venv_root $PWD
                source .venv/bin/activate.fish
            end
        else
            if set -q VIRTUAL_ENV
                if set -q venv_root
                    if not string match --entire --quiet $venv_root $PWD
                        set --erase venv_root
                        deactivate
                    end
                end
            end
        end
    end

    # in case the shell is started in a directory which contains a virtualenv
    auto_virtualenv

@izaakf
Copy link
Author

izaakf commented Oct 17, 2022

I thought this repo was stupid because I was red pilled by @kennethreitz

Though, after some heavier investigation I realised that this was in fact a great repo. Thanks for including your script I will be sure to use it my dear friend. @franciscolourenco may I ask what you think of this repo? If it is not too personal a question.

@franciscolourenco
Copy link

franciscolourenco commented Oct 17, 2022

@izaakf did @kennethreitz complain about this project?
Only now noticed this
image

@franciscolourenco
Copy link

franciscolourenco commented Oct 17, 2022

@izaakf I dismissed this plugin as a viable choice once I found at least two unresolved issues previously closed (but now re-opened) due to inactivity:

  1. Does not enter pipenv shell when creating new terminal directly in a pipenv folder #20 (comment)
  2. Does not switch pipenv when switching directly to another pipenv folder. #19 (comment)

@franciscolourenco
Copy link

Regarding Pipenv in general, I gave it a try as well as I did with Poetry. It seems that the community hasn't settled for wither, both projects still seem to have some rough edges, and I didn't need any package management functionality for the time being, so I stuck with vanilla virtualenv once I found out it supported fish now.

@izaakf
Copy link
Author

izaakf commented Oct 17, 2022

@kennethreitz complained about me for having an opinion which I find bizarre. It's okay though as I have educated myself on the history of this project. It's fascinating how one small project can have such a profound impact on developers around the world. That's why I fell in love with this project

@izaakf
Copy link
Author

izaakf commented Oct 17, 2022

I understand your dismissal of this plugin due to those open issues. It is a shame they were never resolved and closed due to staleness. If I had the cycles I most certainly would've sought to resolve them myself. If I find the cycles to work on those tasks do you think you would return to use this project @franciscolourenco?

@izaakf
Copy link
Author

izaakf commented Oct 17, 2022

I see, I'm still an avid user of Poetry myself. Despite the lack of community there is still something magical, and whimsical about it. I have been trying to advocate for use of Poetry within crypto and NFT communities as I think they could be easily persuaded to use such a technology. It has been with little success thus far but I feel that with upcoming global events that those in the crypto could still be encouraged to use Poetry.

@franciscolourenco
Copy link

franciscolourenco commented Oct 17, 2022

It's fascinating how one small project can have such a profound impact on developers around the world. That's why I fell in love with this project

I've heard about, and read some interesting blog posts by kennethreitz, but I'm not sure I actually know what you are talking about. However I'm curious to find out :)

If I find the cycles to work on those tasks do you think you would return to use this project @franciscolourenco?

I think I would, if Pipenv works without problems, why not.

I see, I'm still an avid user of Poetry myself

Do you use Poetry instead of Pipenv at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants