fix: add ability to send custom address to calculate plvGLP price

[r0ohafza]

resolves sherlock-audit/2023-01-sentiment-judging#19

[zobront]

I don't think this change solves the issue. Whatever address you enter will not be a partner, which address(0) won't be as well. But I guess that in theory it's safer to use an address you KNOW will never be a partner.

The only way to solve what was brought up is to pass the address of the owner who the oracle is being called on behalf of, which may not be worthwhile.

Otherwise, you are simply accepting that it may the oracle may slightly undervalue assets for users who are partners, which seems reasonable, and this fix is fine.

[r0ohafza]

I don't think this change solves the issue. Whatever address you enter will not be a partner, which address(0) won't be as well. But I guess that in theory it's safer to use an address you KNOW will never be a partner.

The only way to solve what was brought up is to pass the address of the owner who the oracle is being called on behalf of, which may not be worthwhile.

Otherwise, you are simply accepting that it may the oracle may slightly undervalue assets for users who are partners, which seems reasonable, and this fix is fine.

If sentiment accounts become partners then creating an oracle by passing the sentiment account address would account for the partner fee and value the token accurately

[zobront]

Hmm I'm realizing there's a bit of a structural issue here.

Because if that's the case (all Sentiment accounts are partners, account in the Oracle is a partner), then it'll calculate the price correctly for holders and liquidations.

But once it's liquidated, the liquidator will not be a parter, so will get less than expected.

I'm not sure the best way to solve that. Do you have ideas?

[r0ohafza]

Hmm I'm realizing there's a bit of a structural issue here.

Because if that's the case (all Sentiment accounts are partners, account in the Oracle is a partner), then it'll calculate the price correctly for holders and liquidations.

But once it's liquidated, the liquidator will not be a parter, so will get less than expected.

I'm not sure the best way to solve that. Do you have ideas?

Yeah, still not sure how to solve the liquidation issue at the moment, going to put this on hold until then, thanks a lot for your input here!