Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client custom attribute for custom key/values #87

Closed
wants to merge 3 commits into from
Closed

Add client custom attribute for custom key/values #87

wants to merge 3 commits into from

Conversation

blysik
Copy link

@blysik blysik commented Jun 11, 2013

So this passes the tests that I created, copying #85 a lot. However, I don't have a very easy test environment. Can someone help me see if this works?

@blysik
Copy link
Author

blysik commented Jun 11, 2013

I put together a test env, and that won't work. Working on it.

@blysik
Copy link
Author

blysik commented Jun 12, 2013

Okay. This now works in my test environment. Same format as the custom key/values for checks, and usage is the same.

@blysik
Copy link
Author

blysik commented Jun 12, 2013

One thing this doesn't let me do however is call the sensu class from an inherited node definition, and then add a custom key/value to a specific node. Anyone have any ideas on that?

@blysik
Copy link
Author

blysik commented Jun 12, 2013

Thinking about this over night, I can probably accomplish this via a variable set in an ENC. ie, my base sensu call has a custom => $node_custom variable, that's set in the ENC.

@jamtur01
Copy link
Contributor

Closing in favour of #90. Thanks for your contribution! 👍

@jamtur01 jamtur01 closed this Jun 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants