Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow you to disable dashboard authentication #82

Merged
merged 1 commit into from
Dec 1, 2013
Merged

allow you to disable dashboard authentication #82

merged 1 commit into from
Dec 1, 2013

Conversation

chaoranxie
Copy link
Contributor

allow you to disable dashboard authentication by providing empty string '' for username and password

allow you to disable dashboard authentication by providing empty string '' for username and password
@jlambert121
Copy link
Contributor

Is there anything blocking the merge on this I can help clean up?

@jamtur01
Copy link
Contributor

I don't think this is the right implementation but haven't had time to find a better one.

@jlambert121
Copy link
Contributor

Approach or implementation? I'm going to be moving my auth to apache shortly so going to need something similar.

@jamtur01
Copy link
Contributor

Approach - also it needs tests for sure.

@tizzo
Copy link

tizzo commented Nov 4, 2013

I would really like to see this land, I'm using a reverse proxy to secure sensu as well.

@doismellburning
Copy link
Contributor

Yeah, I'd love to see this/something similar hit mainline

jamtur01 added a commit that referenced this pull request Dec 1, 2013
allow you to disable dashboard authentication
@jamtur01 jamtur01 merged commit a978bf1 into sensu:master Dec 1, 2013
@morrisjones
Copy link

Configuring an empty string for the dashboard user/password indeed disables the authentication as desired. However, on my system at least, each puppet run goes through a series of these:

(/Stage[main]/Sensu::Dashboard::Config/Sensu_dashboard_config[monitor1.example.com]/user) user changed '' to ''
(/Stage[main]/Sensu::Dashboard::Config/Sensu_dashboard_config[monitor1.example.com]/password) password changed '' to ''
(/Stage[main]/Sensu::Dashboard::Service/Service[sensu-dashboard]) Triggered 'refresh' from 2 events

So there doesn't appear to be a way to have a clean puppet run without refreshing the dashboard service. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants