Add a notify between server and client when both are running #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the client and the server on the same node, on first run it's possible that the client starts before the server. This appears to cause it not to appear until you manually (or otherwise) kick the client. Adding this notification fixes that problem. For a test case try https://github.com/garethr/sensu-playground. Without this fix the first time the server instance is created the client doesn't register. It's possible it's a bug in the (stripped down) manifests too, if you spot that instead let me know.
jamtur01
added a commit
that referenced
this pull request
Mar 23, 2013
Add a notify between server and client when both are running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the client and the server on the same node, on first run
it's possible that the client starts before the server. This appears to
cause it not to appear until you manually (or otherwise) kick the
client. Adding this notification fixes that problem.
For a test case try https://github.com/garethr/sensu-playground. Without
this fix the first time the server instance is created the client
doesn't register. It's possible it's a bug in the (stripped down)
manifests too, if you spot that instead let me know.