Fixes for dependencies and subscribers properties in sensu::check. #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jonathanio - thanks for this - can you please fix the test failures. Thanks! |
If the dependencies propery is defined in the Puppet resource, the type will alternate between adding and removing it on runs as under the create method it's not added, while subsequently it's not included in the list from check_args. This causes the first run to not add it, the second (and each subsequent even) run to add it in, and then each odd run to remove it as it's now classed as a custom property instead and doesn't match that provided by the resource.
The subscriptions property is an optional one and when set to [] it will always give an empty array in the JSON exported. Setting to undef will clean up any new configuration created (it shouldn't affect existing configuration and puppet will consider undef/nil/empty arrays as equivalent by the looks of it when :array_matching is set in the type).
Fixed the defaults in sensu_check_spec.rb as the default no longer includes an empty array for subscribers.
|
This failure seams to be an issue with the puppet module itself. It fails on my branch and on master on my machine at the moment? |
jamtur01
added a commit
that referenced
this pull request
Jan 13, 2015
Fixes for dependencies and subscribers properties in sensu::check.
thejandroman
pushed a commit
to Ensighten/sensu-puppet
that referenced
this pull request
Aug 2, 2016
thejandroman
pushed a commit
to Ensighten/sensu-puppet
that referenced
this pull request
Aug 5, 2016
thejandroman
pushed a commit
to Ensighten/sensu-puppet
that referenced
this pull request
Aug 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with the Puppet configuration: