Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rabbitmq ssl config #268

Merged
merged 1 commit into from
Nov 14, 2014
Merged

Conversation

patrick-minted
Copy link

The intent, per the comments in the module, is that $sensu::rabbitmq_ssl
would be set to true if you set either a certificate or a key. That var
defaults to false. Current code does not actually override this value.
When the sensu_rabbitmq_config is called, it directly references this var,
so unless you've specifically set it in your config, it's always false.
This makes it behave the way the module comments describe.

The intent, per the comments in the module, is that $sensu::rabbitmq_ssl
would be set to true if you set either a certificate or a key. That var
defaults to false. Current code does not actually override this value.
When the sensu_rabbitmq_config is called, it directly references this var,
so unless you've specifically set it in your config, it's always false.
This makes it behave the way the module comments describe.
@patrick-minted
Copy link
Author

I opened this before I had actually tested it. I've now verified it works, but it also adds a requirement for an update to erlang, which I solved in my setup by adding the 'garethr-erlang' module from the forge and ensuring it installs before rabbitmq. That fix is specific for Ubuntu, but the nice thing about adding in that module is it covers several OS bases. Without it you get the stock erlang-nox package, which has a vulnerability. Rabbitmq-server will disable ssl without a patched version of erlang-nox.

I'm not sure how you all would like to address the dependency in your repo (or if you just want to add it to the docs...)

edit: the requirement only applies if you want to use ssl with rabbitmq.

jlambert121 added a commit that referenced this pull request Nov 14, 2014
@jlambert121 jlambert121 merged commit e907fe8 into sensu:master Nov 14, 2014
@jlambert121
Copy link
Contributor

Thanks @patrick-minted. I think managing erlang is outside the scope of this module, but should be managed closer to the actual rabbitmq install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants