Fix puppet lib loading issues #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. Looks like some test failures as a result of this. Can you take a look at them? |
|
will investigate |
|
I think it was typo in ruby spec file (not mine, it was already in master), making the test builds failed in 1.9.3 and 2.0.0 |
jamtur01
added a commit
that referenced
this pull request
Jan 18, 2014
Fix puppet lib loading issues
|
Thanks - awesome stuff! :) |
|
@zdenekjanda thank you for this - this has been bugging me and I have not been able to figure out out! This fix didn't resolve everything right away for me, but I figured out the providers needed to go one level higher (and I incorrectly changed the type as well but reverted it). This is great, thank you again for this. Please let me know if my changes break anything you can find. |
|
I pulled and retested and works for me too, glad we busted this nasty bug :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue for certain versions of puppet where it can't find puppet_x.