Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add puppet 3.4, remove puppet 3.0 testing #117

Merged
merged 3 commits into from
Dec 26, 2013
Merged

add puppet 3.4, remove puppet 3.0 testing #117

merged 3 commits into from
Dec 26, 2013

Conversation

jlambert121
Copy link
Contributor

Add puppet 3.4 to travis tests
Not pinning rspec-puppet to pre-1.0 so hash validation works in tests, but this means we run into a puppet 3.0.x bug related to autoloading - removing puppet 3.0.x from tests.

@jlambert121
Copy link
Contributor Author

Travis is still not honoring the exclude matrix. There's another failure as well I haven't seen before as well, looking into it.

@jlambert121
Copy link
Contributor Author

Deleted .travis.yml and typed it in a new file by hand to ensure there was nothing funny at all with spacing, hidden/special characters. I'm at a loss and haven't had any love in the irc channel. Do you know any other way to get someone at travis to maybe give us a hand with the exclude matrix not working? I'm out of ideas on this one.

@jlambert121
Copy link
Contributor Author

Fixed finally!

Since this project does not use the default Gemfile, gemfile becomes part of the environment needed for the exclusion.

jamtur01 added a commit that referenced this pull request Dec 26, 2013
add puppet 3.4, remove puppet 3.0 testing
@jamtur01 jamtur01 merged commit 3cf0363 into sensu:master Dec 26, 2013
@jamtur01
Copy link
Contributor

Woot! Thanks Justin! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants